Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static typings, underscore properties & security vulnerabilities #59

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

DonovanDMC
Copy link

This:

  • makes typings static, as generated types are usually either lacking information or are less than helpful
  • adds underscore properties via defineProperty, to make the non-enumerable
  • updates jsdoc-to-markdown from 6.0.1 to 7.1.1 (I saw no changes in the generated docs)

I've left any methods/properties that begin with underscores out of the types, assuming they're "private"/"internal" methods and shouldn't be used
This ties in with jirenius/modapp-eventbus#1, the comment on line 23 can be removed if that goes through

@DonovanDMC DonovanDMC marked this pull request as draft July 11, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant