Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated example_project #87

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Updated example_project #87

merged 2 commits into from
Feb 21, 2022

Conversation

dalinel
Copy link
Contributor

@dalinel dalinel commented Feb 11, 2022

This is updating and adding tutorials to the example project
It solves #85

@dalinel dalinel changed the title Update example Updated example_project Feb 11, 2022
@jbmouret
Copy link
Member

Thank you. It looks good.

One question is the absolute paths in the config file (for the URDF, in particular) : in works in the docker, but this is still an absolute path... One idea would be to use utheque.hpp to find the URDF. The problem is that this adds a dependency, but on the other hand this is a cleaner approach (and no need to compile robot_dart for utheque only).

What do you think?

@dalinel
Copy link
Contributor Author

dalinel commented Feb 11, 2022

Yes true it would be cleaner to use utheque.hpp
What do you think about adding an option COMPILE_UTHEQUE_EXAMPLES as we did for robot_dart here ?
The dependency would then be optional

@jbmouret
Copy link
Member

My idea was to use utheque when we load the urdf in the controller. In that case. We could make it a light dependency with #ifdef : if utheque, is not found, we use the path directly, otherwise we call utheque.

@dalinel
Copy link
Contributor Author

dalinel commented Feb 11, 2022

ok yes this is better and lighter

@jbmouret
Copy link
Member

see #88

@dalinel dalinel merged commit dec3482 into devel Feb 21, 2022
@dalinel dalinel deleted the update_example branch February 21, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants