Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop specact 1 #128

Merged
merged 8 commits into from
Jan 3, 2024

Conversation

rburghol
Copy link
Contributor

@rburghol rburghol commented Dec 27, 2023

Simple special ACTION integration with full STATE support (see #90). I have outlined the process and functions needed to integrate other special actions (and any advanced components) in #127

Note:

  • The date matching facility is not yet implemented
  • The short hand which allows users to repeat the same action for from RANGE1 to RANGE2 segments not yet implemented
    • need to decide where to do so, in the parser, in SPECL.py object loading, in a SpecialAction object creation method, or static method called from SPECL.py
  • Need to discuss and decide on verbose domain specific paths are needed or not, for example:
    • Old special ACTIONS only gave a variable name, and segment ID, such as IVOL, and did not give the activity, such as HYDR, thus the function only has info to give a path like /STATE/RCHRES_R001/IVOL, which could allow for collisions.
    • Current proposed method of storing STATE for things like IVOL, use a domain specific path which includes activity, such as /STATE/RCHRES_R001/HYDR/IVOL
    • If HSPF has no name collisions, it is totally OK to use the shorter nomenclature, but it is a trade-off between extensibility and convention. To support the more verbose proposed method we would need some sort of function to perform a lookup, i.e. like def find_hspf_activity(varname)

@rburghol rburghol mentioned this pull request Dec 27, 2023
26 tasks
@PaulDudaRESPEC PaulDudaRESPEC merged commit bf62e28 into respec:develop-specact Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants