Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Extension keyword the '*' after can't control side bar. #240

Closed
gtk2k opened this issue Jul 2, 2020 · 10 comments · Fixed by #288
Closed

Search Extension keyword the '*' after can't control side bar. #240

gtk2k opened this issue Jul 2, 2020 · 10 comments · Fixed by #288
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@gtk2k
Copy link

gtk2k commented Jul 2, 2020

Search Extension keyword input '*' and Enter key.
After can't control side bar.

@jjavierdguezas
Copy link
Contributor

Version: 0.5.0
Electron: 8.3.0
Chrome: 80.0.3987.165
Node.js: 12.13.0
V8: 8.0.426.27-electron.0
OS: Windows_NT x64 10.0.18362

extensions

After some clicks the error shows. here a pastebin of the JSON

cc: @manojVivek

@manojVivek
Copy link
Collaborator

@jjavierdguezas Great, thanks for the triage.

@RomainFrancony Maybe be we should add some validation on the input box?

@manojVivek manojVivek added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jul 2, 2020
@RomainFrancony
Copy link
Contributor

@manojVivek I don't know the exact specification of Chrome Store extension's ID but it seems that they are only composed of letters, so probably a regex like /[a-z]+/i

@manojVivek
Copy link
Collaborator

Yeah, the extension id is composed of lower case alphabets.

@jjavierdguezas
Copy link
Contributor

@RomainFrancony @manojVivek I could only find that they are always 32 characters long
see here
image

@pajaydev
Copy link
Contributor

pajaydev commented Jul 3, 2020

I would like to work on this if it's unassigned. Thanks.

@manojVivek
Copy link
Collaborator

@pajaydev Appreciate it, I'm assigning it to you. 🙌

cc: @RomainFrancony

@manojVivek
Copy link
Collaborator

@pajaydev Please join us on Gitter if you have any questions along the way - https://gitter.im/responsively-app/

@pajaydev
Copy link
Contributor

pajaydev commented Jul 5, 2020

@manojVivek Thank you

@pajaydev
Copy link
Contributor

pajaydev commented Jul 8, 2020

@manojVivek I have created a PR, kindly review

@manojVivek manojVivek added this to the v.0.7.0 milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants