Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle anchor tags with target = blank #261

Closed
jjavierdguezas opened this issue Jul 3, 2020 · 2 comments · Fixed by #274
Closed

Handle anchor tags with target = blank #261

jjavierdguezas opened this issue Jul 3, 2020 · 2 comments · Fixed by #274
Assignees
@jjavierdguezas
Labels
enhancement New feature or request
Milestone
v0.6.0

Comments

@jjavierdguezas
Copy link
Contributor

jjavierdguezas commented Jul 3, 2020 •
edited
Loading

Version: 0.5.0
Electron: 8.3.0
Chrome: 80.0.3987.165
Node.js: 12.13.0
V8: 8.0.426.27-electron.0
OS: Windows_NT x64 10.0.18362

Right now Responsively App does not handle <a/> tags with target="_blank" prop so clicking on them does nothing

For example create an index.html with the following:

<!DOCTYPE html>
<html>
<body>
<a href="https://responsively.app/" target="_blank">CLICK</a>
</body>
</html>

Open it with Chrome and click on the link, a new tab opens on the Responsively App website
Open it with Responsively App and click the link.... Nothing happens

I think that it should go to the website inside Responsively App or open it on the default browser..
@jjavierdguezas
Copy link
Contributor Author

@manojVivek maybe this answer on StackOverflow can help and also take into account this issue

@manojVivek
Copy link
Collaborator

Yes @jjavierdguezas, This is related to the #248 as well, where OAuth login flow is getting blocked.

We should make it open one new browser window so that the user gets a feel of how the app will work in the regular browser.

@jjavierdguezas jjavierdguezas mentioned this issue Jul 4, 2020
Merged
@manojVivek manojVivek added the enhancement New feature or request label Jul 5, 2020
@manojVivek manojVivek added this to the v0.6.0 milestone Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjavierdguezas jjavierdguezas

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Handle anchor elements that open new windows (target="_blank") jjavierdguezas/responsively-app
2 participants
@manojVivek @jjavierdguezas