Navigation bar working with both Bootstrap 2 and Bootstrap 3 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2014
Open
|
I'm not sure if there are other issues that need to be fixed with bootstrap 3, but I'm going to merge this since not being able to see the menu seems like a pretty critical bug. @jph would you be willing to make new issues if you notice any new problems with bootstrap 3? I know you already mentioned a problem with some kind of background highlight on the menu buttons, if you could make an issue for that after I merge this that would be great. Thanks! @darinkrauss thanks for your work! |
mcfiredrill
added a commit
that referenced
this pull request
Aug 22, 2014
Navigation bar working with both Bootstrap 2 and Bootstrap 3
|
Yes, I will work through any more display issues I find and submit issues. |
|
@jph Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[rebased] I believe these limited changes will allow the Resque Web navigation bar to appear properly under both Bootstrap 2 and Bootstrap 3. Not sure if any other changes are required for Bootstrap 3.