Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TRestEventRateAnalysisProcess.cxx #194

Merged
merged 1 commit into from
May 5, 2022
Merged

Update TRestEventRateAnalysisProcess.cxx #194

merged 1 commit into from
May 5, 2022

Conversation

DavidDiezIb
Copy link
Member

@DavidDiezIb DavidDiezIb commented May 4, 2022 •
edited by pull-request-badge bot

DavidDiezIb Ok: 1

Member inside process should be observable instead of observables. Changed in documentation.

@jgalan jgalan self-requested a review May 4, 2022 10:14
@lobis lobis self-requested a review May 4, 2022 10:40
@jgalan
Copy link
Member

jgalan commented May 4, 2022 •
edited

Hi @DavidDiezIb you still need to merge this PR. Normally you should merge master into your branch and push again to double-check. In fact, in this occasion, it would fix the pipeline.

Still, since the PR is harmless, there is no problem to merge it already.

@DavidDiezIb
Copy link
Member Author

Yes, sorry, @lobis told me yesterday.

@DavidDiezIb DavidDiezIb merged commit 7ad1297 into master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgalan jgalan jgalan approved these changes

@lobis lobis lobis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DavidDiezIb @jgalan @lobis