Update TRestMetadata classes default title and name #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiple metadata are not explicitly named (names must be unique in file)
…td::to_string(true)`
…by removing `std::`
juanangp
approved these changes
Aug 29, 2022
DavidDiezIb
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR all
TRestMetadataclasses were usingdefaultNameanddefaultTitlefor the default value of said parameters. This was causing an issue when multiple metadata classes were left with the default name values, as the name needs to be unique in the root file.This PR updates the name of these parameters so that it depends on the class name (
defaultName->defaultTRestGeant4Metadataetc.). This way if the metadata classes are unique in the root file there won't be a problem even if they are not explicitly named (such is the case inrestG4simulations).I also updated the
REST_StringHelper::StringToBoolto also supportstd::to_string(true)as argument and normalized the usage ofstd::in the source file.I had to add 5e78026 to fix compilation issues related to reflection, perhaps @nkx111 could take a look and prevent these from happening in the future.