Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplyCut will be always called #334

Merged
merged 4 commits into from
Dec 1, 2022
Merged

ApplyCut will be always called #334

merged 4 commits into from
Dec 1, 2022

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Nov 24, 2022

jgalan Ok: 4

Not sure if this could be a performance issue, but I guess it will not be called in case cutsEnabled is false.

@jgalan
Copy link
Member Author

jgalan commented Nov 28, 2022

Hi @cmargalejo I just added a new commit. I tested it and it was working for me using the example 03.Fluorescence from restG4.

I tested changing g4Analysis.rml with the following:

        <addProcess type="TRestGeant4AnalysisProcess" name="g4Ana" value="ON" cutsEnabled="true">
            <cut name="totalEdep" value="(5,10)" />
            <parameter name="observable" value="all"/>
        </addProcess>

|

@jgalan jgalan marked this pull request as ready for review November 28, 2022 19:20
@jgalan
Copy link
Member Author

jgalan commented Nov 28, 2022

I introduced ApplyCut at each loop where ProcessEvent is called. I was not sure if this was necessary at any of them. @nkx

@jgalan
Copy link
Member Author

jgalan commented Nov 30, 2022

Perhaps we should merge as soon as @cmargalejo states the cuts are working on her side

@cmargalejo cmargalejo merged commit 613780a into master Dec 1, 2022
@lobis lobis deleted the jgalan_applyCut_always branch December 1, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants