Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes MacOs installation #337

Merged
merged 7 commits into from
Nov 29, 2022
Merged

Fixes MacOs installation #337

merged 7 commits into from
Nov 29, 2022

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Nov 28, 2022 •
edited by pull-request-badge bot
Loading

jgalan Ok: 74

  • Updated installROOT.sh so that it works on one round in MacOs.
  • Added required unistd.h headers for MacOs compilation encapsulated under __APPLE__.
  • Encapsulating c++fs library linking causing problems on MacOs.
  • Now CMAKE_INSTALL_PREFIX must be defined by user, if not cmake will prompt an error.

@jgalan jgalan marked this pull request as ready for review November 29, 2022 10:18
@jgalan jgalan requested review from lobis, nkx111, juanangp and a team November 29, 2022 10:18
@jgalan jgalan merged commit b029a9f into master Nov 29, 2022
@jgalan jgalan deleted the jgalan_macos_fixes branch November 29, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradAltenmueller KonradAltenmueller KonradAltenmueller approved these changes

@lobis lobis lobis approved these changes

@nkx111 nkx111 Awaiting requested review from nkx111 nkx111 is a code owner

@juanangp juanangp Awaiting requested review from juanangp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgalan @lobis @KonradAltenmueller