Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading root installation to root-6.26.10 #361

Merged
merged 7 commits into from
Jan 25, 2023
Merged

Upgrading root installation to root-6.26.10 #361

merged 7 commits into from
Jan 25, 2023

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Jan 12, 2023

juanangp Ok: 36

  • Upgrading installation from root-6.24.2 to root-6.26.10, minor changes added on cmake flags
  • scripts/installation/installGarfield.sh updated to tags/4.0. Also reviewed and removed GARFIELD_HOME which is obsolete now.

@juanangp juanangp requested review from jgalan, lobis and a team January 12, 2023 10:16
@juanangp
Copy link
Member Author

I have tested on Ubuntu 20.04 (WSL) and it is working properly @jgalan perhaps you can test on MAC to check that it is working as well?

make -j30
make install
cmake -DCMAKE_CXX_STANDARD=17 -DCMAKE_INSTALL_PREFIX=${ROOT_DIR}/install ../source
make -j8 install
Copy link
Member

@lobis lobis Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make -j8 install
make -j$(($(nproc) - 1)) install

I updated the option to use as many threads as cores minus 1.

Copy link
Member Author

@juanangp juanangp Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While doing that my computer got stuck since it is running out of resources, perhaps we can check nproc and remove some cores?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without a number it might take all the CPUs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might use: cat /proc/cpuinfo | grep processor | wc -l? And take half the number of CPUs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated my suggestion to use all minus 1 cores, I remember on some other project's documentation this is the recommended way, I have never seen half the number of cpu as recommended anywhere but we can also try it if this doesn't work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 12 cores in my WSL, but I already had issues using 10, so I think the safest is to go to the half of the cores.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO, cannot we do ($(nproc)/2)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, make -j8 is probably ok, perhaps even make -j4. Better to avoid problems.

@jgalan
Copy link
Member

jgalan commented Jan 12, 2023

I have tested on Ubuntu 20.04 (WSL) and it is working properly @jgalan perhaps you can test on MAC to check that it is working as well?

I go for it

@lobis
Copy link
Member

lobis commented Jan 12, 2023

I have tested on Ubuntu 20.04 (WSL) and it is working properly @jgalan perhaps you can test on MAC to check that it is working as well?

I will test REST compilation with root binaries (6.22.10) on Ubuntu 22.04 (WSL). I think this should be the recommended installation method for root if it's not already (if it works).

@juanangp
Copy link
Member Author

Ubuntu 22.04 (WSL)

I am targeting Ubuntu 20.04 and root 6.26.10. I was not able to find Ubuntu 22.04 (WSL) using command prompt, but I see it is available in Microsoft Store.

@jgalan
Copy link
Member

jgalan commented Jan 12, 2023

For info I got the following error on MacOs

-- Found GLEW: /usr/local/lib/cmake/glew/glew-config.cmake  
CMake Error at cmake/modules/SearchInstalledSoftware.cmake:614 (message):
  Please enable builtin Glew due bug in latest CMake (use cmake option
  -Dbuiltin_glew=ON).
Call Stack (most recent call first):
  CMakeLists.txt:245 (include)

@juanangp
Copy link
Member Author

For info I got the following error on MacOs

-- Found GLEW: /usr/local/lib/cmake/glew/glew-config.cmake  
CMake Error at cmake/modules/SearchInstalledSoftware.cmake:614 (message):
  Please enable builtin Glew due bug in latest CMake (use cmake option
  -Dbuiltin_glew=ON).
Call Stack (most recent call first):
  CMakeLists.txt:245 (include)

Ok, I just revert the changes on cmake params, it is weird since it is working properly on Linux

@jgalan
Copy link
Member

jgalan commented Jan 12, 2023

Ok, for me in MacOs, after adding -Dbuiltin_glew=ON to the cmake succeeds. It must be noted that glew-dev libraries were installed on my system.

Copy link
Member

@jgalan jgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on MacOs Ventura 13.1

@jgalan
Copy link
Member

jgalan commented Jan 12, 2023

I also checked ./installGarfield.sh and worked properly on MacOs

@lobis lobis merged commit c4db169 into master Jan 25, 2023
@lobis lobis deleted the root-6.26.10 branch January 25, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants