-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading root installation to root-6.26.10 #361
Conversation
I have tested on Ubuntu 20.04 (WSL) and it is working properly @jgalan perhaps you can test on MAC to check that it is working as well? |
make -j30 | ||
make install | ||
cmake -DCMAKE_CXX_STANDARD=17 -DCMAKE_INSTALL_PREFIX=${ROOT_DIR}/install ../source | ||
make -j8 install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make -j8 install | |
make -j$(($(nproc) - 1)) install |
I updated the option to use as many threads as cores minus 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While doing that my computer got stuck since it is running out of resources, perhaps we can check nproc
and remove some cores?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without a number it might take all the CPUs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might use: cat /proc/cpuinfo | grep processor | wc -l
? And take half the number of CPUs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated my suggestion to use all minus 1 cores, I remember on some other project's documentation this is the recommended way, I have never seen half the number of cpu as recommended anywhere but we can also try it if this doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 12 cores in my WSL, but I already had issues using 10, so I think the safest is to go to the half of the cores.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SO, cannot we do ($(nproc)/2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, make -j8
is probably ok, perhaps even make -j4
. Better to avoid problems.
I go for it |
I will test REST compilation with root binaries (6.22.10) on Ubuntu 22.04 (WSL). I think this should be the recommended installation method for root if it's not already (if it works). |
I am targeting Ubuntu 20.04 and root 6.26.10. I was not able to find Ubuntu 22.04 (WSL) using command prompt, but I see it is available in Microsoft Store. |
For info I got the following error on MacOs
|
Ok, I just revert the changes on cmake params, it is weird since it is working properly on Linux |
Ok, for me in MacOs, after adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me on MacOs Ventura 13.1
I also checked |
scripts/installation/installGarfield.sh
updated to tags/4.0. Also reviewed and removed GARFIELD_HOME which is obsolete now.