Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let RestateDeployer wait until the schema information has propagated to the ingress #266

Open
tillrohrmann opened this issue Feb 14, 2024 · 0 comments
Open

Let RestateDeployer wait until the schema information has propagated to the ingress #266

tillrohrmann opened this issue Feb 14, 2024 · 0 comments
Assignees
@tillrohrmann

Comments

@tillrohrmann
Copy link
Contributor

With the changes introduced via restatedev/restate#1180, the ingress won't immediately learn about a newly registered service since the information needs to be propagated. To solve this problem, we can let the RestateDeployer wait until the health check returns serving for the registered services.
@tillrohrmann tillrohrmann self-assigned this Feb 14, 2024
tillrohrmann added a commit to tillrohrmann/e2e that referenced this issue Feb 14, 2024
@tillrohrmann
Wait for service availability at the ingress before running tests
49edea2 
This commit makes the RestateDeployer wait for the availability of registered
services at the ingress. The deployer checks whether the ingress is serving
the registered services via calling grpc.health.v1.Health/Check and checking
that the response contains status = SERVING.

This fixes restatedev#266.
@tillrohrmann tillrohrmann mentioned this issue Feb 14, 2024
Closed
tillrohrmann added a commit to tillrohrmann/e2e that referenced this issue Feb 14, 2024
@tillrohrmann
Wait for service availability at the ingress before running tests
551fe3d 
This commit makes the RestateDeployer wait for the availability of registered
services at the ingress. The deployer checks whether the ingress is serving
the registered services via calling grpc.health.v1.Health/Check and checking
that the response contains status = SERVING.

This fixes restatedev#266.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tillrohrmann tillrohrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wait for service availability at the ingress before running tests tillrohrmann/e2e
1 participant
@tillrohrmann