End of stream message #1012
Merged
End of stream message #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
service-protocol/issues/49
branch
from
6fab876
to
33afbe5
Compare
|
I updated this PR based on restatedev/service-protocol#61 |
slinkydeveloper
force-pushed
the
service-protocol/issues/49
branch
from
33afbe5
to
47c9ed7
Compare
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. The changes look good to me. I had one clarifying question about the newly introduce caching of journal appends.
crates/worker/src/partition/services/non_deterministic/remote_context.rs
Show resolved
Hide resolved
crates/worker/src/partition/services/non_deterministic/remote_context.rs
Outdated
Show resolved
Hide resolved
slinkydeveloper
force-pushed
the
service-protocol/issues/49
branch
from
4fd9c66
to
536f356
Compare
tillrohrmann
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Thanks for updating this PR @slinkydeveloper. The changes look good to me. +1 for merging after resolving the last few comments.
crates/worker/src/partition/services/non_deterministic/remote_context.rs
Outdated
Show resolved
Hide resolved
crates/worker/src/partition/services/non_deterministic/remote_context.rs
Outdated
Show resolved
Hide resolved
…da8bd..8a5b9770 8a5b9770 Reintroduce error message (restatedev#61) 5417feeb Modify End of Stream. (restatedev#51) git-subtree-dir: crates/service-protocol/service-protocol git-subtree-split: 8a5b9770425dc8c6683ab744c0d5abb258e04467
* Handle EndMessage in invoker * Remove special handling of OutputStreamEntry. This is now not needed anymore. * Update RemoteContext to support EndMessage. In order to support EndMessage with a similar behavior to the invoker/PP, we now first write the output stream entry, then on EndMessage we transition to Done and send the result back. To support read your own writes, the StateTransitions (now StateAndJournalTransitions) supports deferring the creation of append journal entry effects. * Update wireshark protocol dissector
slinkydeveloper
force-pushed
the
service-protocol/issues/49
branch
from
6ff472d
to
19590d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of restatedev/service-protocol#49