Send ingress responses directly to ingress #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedSoliman
approved these changes
Feb 23, 2024
tillrohrmann
force-pushed
the
issues/1210
branch
from
56085dd
to
1729503
Compare
This commit changes how ingress responses are sent to the ingress. Before, they went through the outbox. Now, they are directly sent to the ingress. This extends a bit the cases in which we cannot deliver an ingress response to the ingress but this does not matter too much since we cannot guarantee ingress response delivery in the general case. As part of this change, this commit also removes no longer used parts of the network router and the ingress acking. This fixes restatedev#1210.
tillrohrmann
force-pushed
the
issues/1210
branch
from
1729503
to
9eeaaeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how ingress responses are sent to the ingress. Before, they went through the outbox. Now, they are directly sent to the ingress. This extends a bit the cases in which we cannot deliver an ingress response to the ingress but this does not matter too much since we cannot guarantee ingress response delivery in the general case.
As part of this change, this commit also removes no longer used parts of the network router and the ingress acking.
This fixes #1210.