Integrate local metadata store into the Node #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs restatedev/e2e#292 to make the e2e tests working because the e2e tests depend on the config schema which was changed with this PR. |
AhmedSoliman
approved these changes
Mar 26, 2024
Comment on lines
+80
to
+86
| let (wipe_meta, wipe_worker, wipe_local_loglet, wipe_local_metadata_store) = match mode { | ||
| Some(WipeMode::Worker) => (false, true, true, false), | ||
| Some(WipeMode::Meta) => (true, false, false, false), | ||
| Some(WipeMode::LocalLoglet) => (false, false, true, false), | ||
| Some(WipeMode::LocalMetadataStore) => (false, false, false, true), | ||
| Some(WipeMode::All) => (true, true, true, true), | ||
| None => (false, false, false, false), |
tillrohrmann
force-pushed
the
issues/1296
branch
from
9f19589
to
d39d0c9
Compare
With retry_if it is now possible to check the error and decide whether to continue retrying or not.
This commit integrates the local metadata store into the Node. It achieves it by introducing the MetadataStore role and requiring that the bootstrap node runs it. The role is the first started role. It runs the LocalMetadataStoreService. After starting the MetadataStore, the node tries to upsert the new NodeConfig with which it announces its NodeId, address and roles it runs. This fixes restatedev#1296.
tillrohrmann
force-pushed
the
issues/1296
branch
from
d39d0c9
to
56b4bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit integrates the local metadata store into the Node. It achieves it by introducing the MetadataStore role and requiring that the bootstrap node runs it. The role is the first started role. It runs the LocalMetadataStoreService. After starting the MetadataStore, the node tries to upsert the new NodeConfig with which it announces its NodeId, address and roles it runs.
This fixes #1296.