Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More metrics on PP loop. #1497

Merged
merged 2 commits into from
May 14, 2024
Merged

More metrics on PP loop. #1497

merged 2 commits into from
May 14, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented May 3, 2024 •
edited
Loading

More metrics on PP loop.

I'll rework the async telemetry technique in a future follow PR to ensure we have correct understanding of latencies.

Stack created with Sapling. Best reviewed with ReviewStack.

@AhmedSoliman AhmedSoliman mentioned this pull request May 3, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

Test Results

 99 files  ±0   99 suites  ±0   8m 3s ⏱️ -25s
 84 tests ±0   82 ✅ ±0  2 💤 ±0  0 ❌ ±0 
216 runs  ±0  210 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 22a5244. ± Comparison against base commit a7e81b0.

♻️ This comment has been updated with latest results.

This was referenced May 10, 2024
Merged
Merged
@AhmedSoliman AhmedSoliman changed the title More metrics on PP loop More metrics on PP loop. I'll rework the async telemetry technique in a future follow PR to ensure we have correct under May 14, 2024
@AhmedSoliman AhmedSoliman marked this pull request as ready for review May 14, 2024 11:15
@AhmedSoliman AhmedSoliman changed the title More metrics on PP loop. I'll rework the async telemetry technique in a future follow PR to ensure we have correct under More metrics on PP loop. May 14, 2024
tillrohrmann
tillrohrmann approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging :-)

@AhmedSoliman AhmedSoliman mentioned this pull request May 14, 2024
Merged
@AhmedSoliman
Tuning and combined improvements for perf and observability
4c829d0
@AhmedSoliman
More metrics on PP loop.
210c0e9 
I'll rework the async telemetry technique in a future follow PR to ensure we have correct understanding of latencies.
@AhmedSoliman AhmedSoliman merged commit 210c0e9 into main May 14, 2024
10 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1497 branch May 14, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @tillrohrmann