Persist min/max supported protocol versions by a service endpoint #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
commented
May 13, 2024
|
|
||
| Suggestions: | ||
|
|
||
| * Check the compatibility matrix between SDK and server versions |
There was a problem hiding this comment.
We could definitely use a page in the documentation for that.
There was a problem hiding this comment.
Once we have it, we can link it from this error.
This isn't implemented in this PR and will be done by a follow-up PR. |
|
Thanks for your review @slinkydeveloper. I've addressed your comments and pushed an update. PTAL. |
slinkydeveloper
approved these changes
May 16, 2024
…361ef..1898426f 1898426f Update min/max of protocol version fields in endpoint_manifest_schema 08871e0b Introduce service.Version and discovery.Version enums 2f3e461f Workflow api changes (restatedev#91) 1fa71a5b Add versioning info (restatedev#90) git-subtree-dir: crates/service-protocol/service-protocol git-subtree-split: 1898426fc98c16d704068594cd54394912845ff7
This commit validates and persists the reported min/max protocol version for a service endpoint in the DeploymentMetadata. This fixes restatedev#1507.
Most likely, a DiscoveryError::BadResponse is caused by an incompatible service endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit validates and persists the reported min/max protocol version
for a service endpoint in the DeploymentMetadata.
This fixes #1507.