Prevent race condition in ResponseTracker by using entry which holds the lock #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
changed the title
AhmedSoliman
approved these changes
May 21, 2024
|
A note for posterity, we are effectively not vulnerable to this at the moment since all current uses rely on RequestId which is a local atomic counter. |
…the lock This commit resolves the race condition in the ResponseTracer when creating a new token with an existing correlation id and completing the very same correlation id at the same time. The solution is to use the entry method of Dashmap which keeps the lock as long as entry is not dropped. This fixes restatedev#1531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves the race condition in the ResponseTracer when creating a new token with an existing correlation id and completing the very same correlation id at the same time. The solution is to use the entry method of Dashmap which keeps the lock as long as entry is not dropped.
This fixes #1531.