Invocation task inactivity timeout(s) #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested locally and it works, but needs #235 |
tillrohrmann
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. The changes look good to me. +1 for merging after resolving the comments.
src/invoker/src/invocation_task.rs
Outdated
| @@ -51,6 +52,9 @@ pub(crate) enum InvocationTaskError { | |||
| Network(hyper::Error), | |||
| #[error("unexpected join error, looks like hyper panicked: {0}")] | |||
| UnexpectedJoinError(#[from] JoinError), | |||
| // TODO introduce hint with CodedError to increase timeout config | |||
src/invoker/src/invocation_task.rs
Outdated
| @@ -374,19 +386,35 @@ where | |||
| } | |||
| } | |||
| }, | |||
| _ = tokio::time::sleep(self.bidi_stream_inactivity_graceful_close_timer) => { | |||
There was a problem hiding this comment.
Great to see how natural the timeout implementation integrates into the existing code :-)
slinkydeveloper
force-pushed
the
issues/222
branch
2 times, most recently
from
77831dd
to
8dd603b
Compare
slinkydeveloper
force-pushed
the
issues/222
branch
from
8dd603b
to
7e54f7b
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #222