Introduce more common types #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalshilman
approved these changes
Feb 3, 2023
src/common/src/types.rs
Outdated
| @@ -1,2 +1,15 @@ | |||
| use uuid::Uuid; | |||
|
|
|||
| /// Identifying a member of a raft group | |||
| pub type PeerId = usize; | |||
There was a problem hiding this comment.
Not that it matters a lot, but usize is a pointer sized type and thus architecture specific (32 or 64 bit) usize
Not that we are planning to support 32 bit systems, but perhaps u64 is a bit safer.
There was a problem hiding this comment.
This makes sense. Will change it.
The new common types are: * LeaderEpoch * PartitionId * PartitionLeaderEpoch * InovcationId This fixes #56.
slinkydeveloper
added a commit
to slinkydeveloper/restate
that referenced
this pull request
Mar 18, 2024
…eb24f..4378d559 4378d559 Move headers into InputStreamEntry. (restatedev#75) 433d4466 Remove the old discovery. Fix restatedev#71 git-subtree-dir: crates/service-protocol/service-protocol git-subtree-split: 4378d559db7a53a477dd091b636a64712b2b630e
slinkydeveloper
added a commit
to slinkydeveloper/restate
that referenced
this pull request
Mar 20, 2024
…eb24f..4378d559 4378d559 Move headers into InputStreamEntry. (restatedev#75) 433d4466 Remove the old discovery. Fix restatedev#71 git-subtree-dir: crates/service-protocol/service-protocol git-subtree-split: 4378d559db7a53a477dd091b636a64712b2b630e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new common types are:
This fixes #56.