New workflow api implementation #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slinkydeveloper
commented
May 15, 2024
slinkydeveloper
commented
- Implement the new workflow service type/handler type
- Add durable promise implementation
- Remove the sdk-workflow-api module
- Simplify the binding of services, no need for the BindableService indirection anymore
Test Results665 tests ± 0 658 ✅ +2 10s ⏱️ - 3m 9s Results for commit 6d23169. ± Comparison against base commit d08025a. This pull request removes 326 and adds 326 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
slinkydeveloper
force-pushed
the
new-workflow-api
branch
from
faaa4ee
to
aa59ac9
Compare
…mpotency key. Add InvocationHandle to attach/get output of invocation Fix CallRequestOptions#withHeader Fix response of attach/getOutput WIP Removing old workflow api and replacing with new stuff Fix code generation to use built-in workflow support. Remove old workflow api. MANY Changes: * Removed the BindableService, and renamed the BindableServiceFactory to ServiceDefinitionFactory. That abstraction was needed to support a "bundle" of many service definitions because of the workflow api. * Removed the manual service builders, we don't need those anymore. * Updated the code to use the new manifest Implement promise api More fixes around promise entries.
slinkydeveloper
force-pushed
the
new-workflow-api
branch
from
aa59ac9
to
6d23169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.