Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to use the Java HttpClient as the default HttpClientE… #3741

Closed
wants to merge 2 commits into from

Conversation

jamezp
Copy link
Contributor

@jamezp jamezp commented Aug 8, 2023

…ngine.

@jamezp jamezp force-pushed the http-client branch 2 times, most recently from 3fa860a to e77295c Compare August 9, 2023 16:27
@liweinan
Copy link
Collaborator

liweinan commented Aug 9, 2023

This is great!

@jamezp
Copy link
Contributor Author

jamezp commented Aug 9, 2023

This is great!

Thank you. I'm not sure why these tests are failing as they pass, at least on Linux, for me locally. I'm on a new laptop so I need to get a new Windows VM setup to test there.

@liweinan
Copy link
Collaborator

liweinan commented Aug 9, 2023

It seems like some random async problems.

@jamezp
Copy link
Contributor Author

jamezp commented Aug 9, 2023

It seems like some random async problems.

Yes, in some cases it looks like the connection gets closed so it could be a real issue. I just have been able to reproduce it.

@jamezp
Copy link
Contributor Author

jamezp commented Aug 9, 2023

Please also see the discussion #3743

…ngine.

Signed-off-by: James R. Perkins <jperkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants