-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift: introduce application credential auth support #2156
Conversation
691f48b
to
1a57e04
Compare
Codecov Report
@@ Coverage Diff @@
## master #2156 +/- ##
==========================================
- Coverage 50.76% 46.74% -4.03%
==========================================
Files 176 176
Lines 14251 14257 +6
==========================================
- Hits 7235 6664 -571
- Misses 5962 6587 +625
+ Partials 1054 1006 -48
Continue to review full report at Codecov.
|
1a57e04
to
a46210e
Compare
@fd0, may I ask you to take a look on this PR? Thanks in advance. |
a46210e
to
6ebcfe7
Compare
rebased on master |
@fd0 kindly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I don't have any means to test this change.
* Swift supports application credentials: restic/restic#2156 * see also fog#533
* Swift supports application credentials: restic/restic#2156 * see also #533
What is the purpose of this change? What does it change?
Add Openstack Auth V3 application credential support.
Was the change discussed in an issue or in the forum before?
#2155
Manual testing could be performed following the steps below:
App cred could be created using the command below (openstack CLI version should be not lower than 3.15):
$ openstack application credential create --secret mysupersecretkey --role swiftoperator --restricted restic
Then, export env variables:
or
Checklist
changelog/unreleased/
that describes the changes for our users (template here)gofmt
on the code in all commits