Allow custom User-Agent to be specified for outgoing requests #4810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konidev20
force-pushed
the
fix-gh-4768-add-custom-user-agent-for-http-client
branch
from
88edf29
to
7d54e2b
Compare
MichaelEischer
requested changes
May 26, 2024
konidev20
force-pushed
the
fix-gh-4768-add-custom-user-agent-for-http-client
branch
from
edd3b41
to
480a813
Compare
MichaelEischer
force-pushed
the
fix-gh-4768-add-custom-user-agent-for-http-client
branch
from
480a813
to
5d7f81f
Compare
MichaelEischer
force-pushed
the
fix-gh-4768-add-custom-user-agent-for-http-client
branch
from
5d7f81f
to
de7b418
Compare
MichaelEischer
approved these changes
May 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Allow custom User-Agent to be specified for outgoing requests. ~~Restic currently uses the default
User-Agentof thenet/httppackage for all outgoing HTTP requests. ~~The customisable User-Agent can be used to differentiate between Restic HTTP client and other golang http clients at a Frontend Gateway or Load Balancer.
Added a global option flag
--http-user-agent.This will wrap the defaulthttp.RoundTripperto set the customUser-Agentheader. If the flag is not specified, the defaultUser-Agentfrom thenet/httppackage is used for outgoing requests.Was the change previously discussed in an issue or on the forum?
#4768
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.