-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: 'query' option in client constructor and per request options #153
Conversation
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that covers a situation when both ?
in the url and the query
object is passed. I think the documentation should also cover this case.
As we have the parsed |
That's a good point, on client constructor we actually don't take default query options, but no reason we couldn't. If anything, it might be more consistent if we do so as it matches behavior of other options. I'll make the change. |
Updated! Per request values override default values. While merging query params seems useful in some scenarios, I think it's easier to override and push any custom merging logic into userland. |
Went to try and fix #134 but could not repro. But added unit tests to make sure this is first class and supported moving fwd.