This repository has been archived by the owner on Aug 10, 2023. It is now read-only.
Fixes both #100 and #101 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +39,13 @@ function bodyParser(options) { | |||
| var parseFieldedText = fieldedTextParser(opts); | |||
|
|
|||
| function parseBody(req, res, next) { | |||
| // #100 don't parse the body again if we've read it once | |||
| if (req._parsedBody) { | |||
| next(); | |||
There was a problem hiding this comment.
Shouldn't we have a lint rule to return on next? return next()
There was a problem hiding this comment.
We do, but this is also scope creep as I'm just being consistent with the rest of the repo. Happy to discuss in a separate issue.
|
@DonutEspresso @rajatkumar any other concerns? |
DonutEspresso
approved these changes
Apr 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes both #100 and #101
#100 Adding bodyParser plugin twice no longer blackholes requests.
#101 Fix failing test by adding
metrics.inflightRequestsas a proxy tounfinishedRequests