This repository has been archived by the owner on Aug 10, 2023. It is now read-only.
bunyan@1.8.6 breaks build 🚨 #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
bunyan just published its new version 1.8.6.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As bunyan is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 29 commits .
4b9df66authors update550ea90Bunyan'ssafeCyclesis too slow when logging large objects. Fixes #4743cde7bctrentm/node-bunyan#401 mkLogEmitter closures unnecessary for disabled log levels and have perf impacte4b33d8added new line for Simple output to PrintHelp (#407)01cb08cFix typo. Fixes #3784474c9amoved the See Also links to https://github.com/trentm/node-bunyan/wiki/Awesome-Bunyanc04e843v1.8.4; fix 'src' usage with node v7e0f0a5dmove 3rd-party list to wiki06dbebddrop unnecessary check, becausetypeof(null)already is "object", excluded in the first guard049f178ignore rotated log files in the test dir2390bf8v1.8.3. Fixlog.info(null)crash that resulted from #426 in v1.8.2.a41539bchange 'make cutarelease' style to not do autocommits and version bumping as part of releasing18bdda7Bump version of dtrace-provider to support Node 6 (#449)d6663a4test: test node v6, drop v57300a18docs: Fix local CLI path (#438)There are 29 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.