Make BuildUrl an extension #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange the type to guard against concurrent updates.
Serializers cache (fixes #1988)
Deploying with
|
| Latest commit: |
bb20dc8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1d9038d3.restsharp.pages.dev |
| Branch Preview URL: | https://buildurl.restsharp.pages.dev |
# Conflicts: # src/RestSharp/Request/RequestContent.cs
|
RestSharp should be versioned with semantic versioning. Changing ParametersCollection is a breaking change The changes are fine to me and reasonable but the version should be changed to to prevent other libraries installing a potential breaking version. The current change will break this pattern. Is this fine for you to change the version to |
|
Yes, the plan is to release the new major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the type for request parameters and default parameters
Default parameters collection locks for concurrent updates (fixed DefaultParameters collection is not read-only #2025)
Add default parameters to the interface
Make
BuildUrla public extension (fixes MakeBuildUripublic #2026)Change authenticator interface to use
IRestClientAlso fix the missing charset for url-encoded forms (fixes No charset in url-encoded form in RestSharp 109.0.1 #2037)
Allow null parameter value in OAuth1 authenticator (fixes OAuth1 AddParameter/AddQueryParameter Empty Value Gets "Value Cannot Be null" Exception #2022)