Skip to content

Commit f24469d

Browse files
committed
[breaking] servers - removing SimpleWebServer's constructor & builder serverId useless field
1 parent 6b20ac6 commit f24469d

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

restx-server-simple/src/main/java/restx/server/simple/simple/SimpleWebServer.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ public static class SimpleWebServerBuilder {
3333
private int port;
3434
private String routerPath = "/api";
3535
private String appBase = null;
36-
private String serverId;
3736
private RestxMainRouter router;
3837
public SimpleWebServerBuilder setPort(int port) {
3938
this.port = port;
@@ -50,23 +49,14 @@ public SimpleWebServerBuilder setAppBase(String appBase) {
5049
return this;
5150
}
5251

53-
public SimpleWebServerBuilder setServerId(String serverId) {
54-
this.serverId = serverId;
55-
return this;
56-
}
57-
5852
public SimpleWebServerBuilder setRouter(RestxMainRouter router) {
5953
this.router = router;
6054
return this;
6155
}
6256

6357
public SimpleWebServer build() {
64-
if (serverId == null) {
65-
serverId = "SimpleWebServer#" + SERVER_ID.incrementAndGet();
66-
}
67-
6858
if (router == null) {
69-
return new SimpleWebServer(serverId, routerPath, appBase, port) {
59+
return new SimpleWebServer(routerPath, appBase, port) {
7060
@Override
7161
protected RestxMainRouter setupRouter() {
7262
return RestxMainRouterFactory.newInstance(
@@ -82,7 +72,7 @@ public synchronized void stop() throws Exception {
8272
}
8373
};
8474
} else {
85-
return new SimpleWebServer(serverId, routerPath, appBase, port) {
75+
return new SimpleWebServer(routerPath, appBase, port) {
8676
@Override
8777
protected RestxMainRouter setupRouter() {
8878
return router;
@@ -104,7 +94,7 @@ public static SimpleWebServerBuilder builder() {
10494
private RestxMainRouter router;
10595
private Connection connection;
10696

107-
private SimpleWebServer(String serverId, String routerPath, String appBase, int port) {
97+
private SimpleWebServer(String routerPath, String appBase, int port) {
10898
super(appBase, port, "localhost", "SimpleFrameowkr", "org.simpleframework", "simple");
10999

110100
this.routerPath = routerPath;

0 commit comments

Comments
 (0)