Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle pb/python #18

Closed
wants to merge 3 commits into from
Closed

Restyle pb/python #18

wants to merge 3 commits into from

Conversation

restyled-io[bot]
Copy link

@restyled-io restyled-io bot commented May 6, 2024

Automated style fixes for #17, created by Restyled.

The following restylers made fixes:

To incorporate these changes, merge this Pull Request into the original. We
recommend using the Squash or Rebase strategies.

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

pbrisbin and others added 3 commits May 6, 2024 08:08
We always specify them now, and we don't use one more than another, so a
default is not useful anyway.
Copy link

github-actions bot commented May 6, 2024

⚠️ This PR generates 3 changes for stacks/restyled.760048635536/us-east-1/mgmt/record-metrics.yaml.

Action Logical Id Physical Id Type Replacement Scope Details
Modify LambdaFunction restyled-record-metrics AWS::Lambda::Function False Properties
  • ParameterReference in Properties (Handler), recreation Never, caused by FunctionHandler
  • DirectModification in Properties (Runtime), recreation Never
  • DirectModification in Properties (Handler), recreation Never
  • ParameterReference in Properties (Runtime), recreation Never, caused by FunctionRuntime
Modify LambdaScheduleRule mgmt-record-metrics-LambdaScheduleRule-Q0HBDLF03FMQ AWS::Events::Rule False Properties
  • ResourceAttribute in Properties (Targets), recreation Never, caused by LambdaFunction.Arn
Modify LambdaSchedulePermission mgmt-record-metrics-LambdaSchedulePermission-1EY5W1N2OEBXN AWS::Lambda::Permission Conditional Properties
  • ResourceAttribute in Properties (SourceArn), recreation Always, caused by LambdaScheduleRule.Arn
Full changes
{
    "capabilities": null,
    "changeSetId": "arn:aws:cloudformation:us-east-1:760048635536:changeSet/stackctl-202405061209-b0549898-4cf5-4086-a66e-d6e4bdff30d3/03d691b5-339d-4d00-a4cc-b603744400ad",
    "changeSetName": "stackctl-202405061209-b0549898-4cf5-4086-a66e-d6e4bdff30d3",
    "changes": [
        {
            "hookInvocationCount": null,
            "resourceChange": {
                "action": "Modify",
                "changeSetId": null,
                "details": [
                    {
                        "causingEntity": "FunctionHandler",
                        "changeSource": "ParameterReference",
                        "evaluation": "Static",
                        "target": {
                            "attribute": "Properties",
                            "name": "Handler",
                            "requiresRecreation": "Never"
                        }
                    },
                    {
                        "causingEntity": null,
                        "changeSource": "DirectModification",
                        "evaluation": "Dynamic",
                        "target": {
                            "attribute": "Properties",
                            "name": "Runtime",
                            "requiresRecreation": "Never"
                        }
                    },
                    {
                        "causingEntity": null,
                        "changeSource": "DirectModification",
                        "evaluation": "Dynamic",
                        "target": {
                            "attribute": "Properties",
                            "name": "Handler",
                            "requiresRecreation": "Never"
                        }
                    },
                    {
                        "causingEntity": "FunctionRuntime",
                        "changeSource": "ParameterReference",
                        "evaluation": "Static",
                        "target": {
                            "attribute": "Properties",
                            "name": "Runtime",
                            "requiresRecreation": "Never"
                        }
                    }
                ],
                "logicalResourceId": "LambdaFunction",
                "moduleInfo": null,
                "physicalResourceId": "restyled-record-metrics",
                "replacement": "False",
                "resourceType": "AWS::Lambda::Function",
                "scope": [
                    "Properties"
                ]
            },
            "type'": "Resource"
        },
        {
            "hookInvocationCount": null,
            "resourceChange": {
                "action": "Modify",
                "changeSetId": null,
                "details": [
                    {
                        "causingEntity": "LambdaScheduleRule.Arn",
                        "changeSource": "ResourceAttribute",
                        "evaluation": "Dynamic",
                        "target": {
                            "attribute": "Properties",
                            "name": "SourceArn",
                            "requiresRecreation": "Always"
                        }
                    }
                ],
                "logicalResourceId": "LambdaSchedulePermission",
                "moduleInfo": null,
                "physicalResourceId": "mgmt-record-metrics-LambdaSchedulePermission-1EY5W1N2OEBXN",
                "replacement": "Conditional",
                "resourceType": "AWS::Lambda::Permission",
                "scope": [
                    "Properties"
                ]
            },
            "type'": "Resource"
        },
        {
            "hookInvocationCount": null,
            "resourceChange": {
                "action": "Modify",
                "changeSetId": null,
                "details": [
                    {
                        "causingEntity": "LambdaFunction.Arn",
                        "changeSource": "ResourceAttribute",
                        "evaluation": "Dynamic",
                        "target": {
                            "attribute": "Properties",
                            "name": "Targets",
                            "requiresRecreation": "Never"
                        }
                    }
                ],
                "logicalResourceId": "LambdaScheduleRule",
                "moduleInfo": null,
                "physicalResourceId": "mgmt-record-metrics-LambdaScheduleRule-Q0HBDLF03FMQ",
                "replacement": "False",
                "resourceType": "AWS::Events::Rule",
                "scope": [
                    "Properties"
                ]
            },
            "type'": "Resource"
        }
    ],
    "creationTime": "2024-05-06T12:09:43Z",
    "description": null,
    "executionStatus": "AVAILABLE",
    "httpStatus": 200,
    "includeNestedStacks": false,
    "nextToken": null,
    "notificationARNs": null,
    "parameters": [
        {
            "parameterKey": "LogInvocation",
            "parameterValue": "False",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "FunctionName",
            "parameterValue": "record-metrics",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "ScheduleExpression",
            "parameterValue": "rate(1 minute)",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "FunctionRuntime",
            "parameterValue": "python3.12",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "FunctionTimeout",
            "parameterValue": "30",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "LogForwarding",
            "parameterValue": "True",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "FunctionRole",
            "parameterValue": "lambda-execution",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "FunctionSourceKey",
            "parameterValue": "src/record-metrics/72cedb92d9dd16fa36588cf788593434b37a3def.zip",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "FunctionSourceBucket",
            "parameterValue": "infra.restyled.io",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "FunctionHandler",
            "parameterValue": "index.handler",
            "resolvedValue": null,
            "usePreviousValue": null
        }
    ],
    "parentChangeSetId": null,
    "rollbackConfiguration": null,
    "rootChangeSetId": null,
    "stackId": "arn:aws:cloudformation:us-east-1:760048635536:stack/mgmt-record-metrics/f0152ce0-b748-11eb-b3e0-129d8c0b3757",
    "stackName": "mgmt-record-metrics",
    "status": "CREATE_COMPLETE",
    "statusReason": null,
    "tags": [
        {
            "key": "CloudGenesis:stack-file",
            "value": "stacks/restyled.760048635536/us-east-1/mgmt/record-metrics.yaml"
        }
    ]
}

Base automatically changed from pb/python to main May 6, 2024 12:12
@restyled-io restyled-io bot closed this May 6, 2024
@restyled-io restyled-io bot deleted the restyled/pb/python branch May 6, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants