Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify 'Trace' library to prevent it from data race issue #171

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Simplify 'Trace' library to prevent it from data race issue #171

merged 4 commits into from
Jan 31, 2024

Conversation

MatsuoTakuro
Copy link
Collaborator

@MatsuoTakuro MatsuoTakuro commented Jan 30, 2024 •
edited
Loading

  • simplify tracing
    • remove TraceableContext and related funcs
    • make it immutable by returning a new context to prevent it from data race
      • data race issue occurs between (*TraceableContext) Pop() as write and *TraceableContext.Done() as read that is triggered by go-sql-driver/mysql.(*mysqlConn).startWatcher such as in the case of a bad connection error.
  • provide option to enable tracing with operation name you like
    • for redis MasterCache and TenantCache

@MatsuoTakuro
simplify tracing
c276429 
     - remove 'TraceableContext' and related funcs
     - make it immutable by returning a new context to prevent it from data race
@MatsuoTakuro
provide option to enable tracing with operation name you like
145f615
@MatsuoTakuro MatsuoTakuro changed the title Simplify tracing Simplify Tracing tools Jan 30, 2024
@MatsuoTakuro MatsuoTakuro changed the title Simplify Tracing tools Simplify Tracing library Jan 30, 2024
@MatsuoTakuro MatsuoTakuro changed the title Simplify Tracing library Simplify 'Trace' library to prevent it from data race issue Jan 30, 2024
@MatsuoTakuro MatsuoTakuro marked this pull request as ready for review January 30, 2024 07:10
@tanvir-retailai tanvir-retailai merged commit 7e50cab into develop Jan 31, 2024
1 check passed
@tanvir-retailai tanvir-retailai deleted the feature/simplify-tracing branch January 31, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongdalu-trechina zhongdalu-trechina zhongdalu-trechina approved these changes

@tanvir-retailai tanvir-retailai Awaiting requested review from tanvir-retailai tanvir-retailai is a code owner

@SunJinping-TRE-C SunJinping-TRE-C Awaiting requested review from SunJinping-TRE-C

@ZhaoYuRetailAI ZhaoYuRetailAI Awaiting requested review from ZhaoYuRetailAI

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatsuoTakuro @zhongdalu-trechina @tanvir-retailai