Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwrap Error in APIError #182

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Unwrap Error in APIError #182

merged 1 commit into from
Mar 15, 2024

Conversation

MatsuoTakuro
Copy link
Collaborator

@MatsuoTakuro MatsuoTakuro commented Mar 14, 2024 •
edited
Loading

  • follow one of conventions in Golang by having a custom error that wraps another error implement Unwrap() error method
  • allow us to utilize errors.Is and As to trace a chain of errors.

@MatsuoTakuro MatsuoTakuro changed the title Unwrap Error in APIError Unwrap Error in APIError Mar 14, 2024
@MatsuoTakuro MatsuoTakuro marked this pull request as ready for review March 14, 2024 08:31
@tanvir-retailai tanvir-retailai merged commit 251c4f3 into develop Mar 15, 2024
1 check passed
@tanvir-retailai tanvir-retailai deleted the feature/unwrap-error-in-apierror branch March 15, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongdalu-trechina zhongdalu-trechina zhongdalu-trechina approved these changes

@tanvir-retailai tanvir-retailai Awaiting requested review from tanvir-retailai tanvir-retailai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatsuoTakuro @zhongdalu-trechina @tanvir-retailai