fix: connection leak during listener close #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Close from LimitListener, falling back on the implementation by the underlying net.Listener. The done channel was needed in the original LimitListener due to it blocking before calling the underlying Listener's Accept. Because closing the underlying listener will cause our call to its Accept to return with an error that we pass along, we don't need to care at all about it. Signed-off-by: Erik Swanson <erik@retailnext.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Close from LimitListener, falling back on the implementation by the
underlying net.Listener. The done channel was needed in the original
LimitListener due to it blocking before calling the underlying Listener's
Accept. Because closing the underlying listener will cause our call to its
Accept to return with an error that we pass along, we don't need to care at
all about it.
Signed-off-by: Erik Swanson erik@retailnext.net