Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File suffix has no dot #42

Closed
beatngu13 opened this issue Oct 18, 2018 · 4 comments
Closed

File suffix has no dot #42

beatngu13 opened this issue Oct 18, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@beatngu13
Copy link
Contributor

As of v0.4.3 (which is essentially this commit), replay results are not properly persisted as they miss the suffix dot (e.g. replayresult instead of replay.result).

Maybe caused by this TODO from RecheckImpl (closed source):

public File getResultFile() {
	return fileNamerStrategy.createFileNamer( execSuiteName )
	// TODO Remove after next release of recheck
	.getResultFile( ReportFileUtils.REPORT_FILE_EXTENSION.substring( 1 ) );
}
@beatngu13 beatngu13 added the bug Something isn't working label Oct 18, 2018
@roesslerj
Copy link
Contributor

This is the wrong order ... closed source retest depends on recheck. So as soon as the parent-pom is switched, and we it depends on recheck 0.4.3 (which it doesn't as of now), this bug is activated. Since Enes did this all locally, he triggered that bug. Good catch, though.

@roesslerj roesslerj reopened this Oct 19, 2018
@roesslerj
Copy link
Contributor

Dammit, I was too tired. Yes, this is a problem that needs to be addressed... reopened until fixed.

@beatngu13
Copy link
Contributor Author

How about a Hotfix of retest with this TODO being addressed, that should do the job?

@beatngu13
Copy link
Contributor Author

Fixed with the release of retest 3.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants