Updating redirect examples to 2.0 to halt confusion #36
Conversation
|
Please wait 60 seconds for container to build the branch. |
|
Disregard, it's in the |
|
@chipotle could you take a look at this? |
|
Should we add a note to the top of the post that states that the post was updated for Horizon 2.0? Otherwise people might look at the date of the post and assume that it uses Horizon 1.0. |
|
@danielmewes to do that we'd need some sort of Jekyll tag which would make the message not show in the blog post preview list as I'd assume we'd want it at the top of the blog post. |
|
Hmm yeah. We could put it at the bottom instead? |
|
I don't think adding a note at the bottom is a bad idea, no. |
|
The deploy has been updated, allow time for Jekyll to rebuild. |
|
Ahh the latest post also doesn't have a <-- more --> which is rendering the whole blog post in the list view. |
|
The deploy has been updated, allow time for Jekyll to rebuild. |
| @@ -514,6 +514,8 @@ to the [official documentation][docs]. | |||
| * Horizon [permissions][permdoc] documentation | |||
| * [Complete source code][repo] of the Thinkmark demo | |||
|
|
|||
| > Note that this post has been updated to use the Horizon 2.0 API | |||
There was a problem hiding this comment.
I know this is nitpicky, but I don't think this should be a block quote; it renders as if it's, well, a quote (indented, different color text, etc.). It'd be better if it were simply an italicized sentence (with a period at the end).
|
Other than my nitpicky comment, this looks good. |
|
Would you mind fixing it and deploying @chipotle? 2016-09-14 10:27 GMT-07:00 Watts Martin notifications@github.com:
|
|
The deploy has been updated, allow time for Jekyll to rebuild. |
|
While Github didn't deign to automatically close this, this is merged as of ec721d0 and deployed. |
Hey @chipotle if you could merge this ASAP some of my sanity might be preserved.
I think a lot of people are discovering Horizon auth through this blog post and as a result are immediately doing it wrong since it's change with the release of 2.0.
If you could review and publish asap I would be in your debt.