Relax Faraday version requirements #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianyamey
reviewed
Sep 29, 2022
bdewater
force-pushed
the
relax-faraday
branch
from
f4ad785
to
d751562
Compare
|
My bad, that was a leftover from when I was trying to make faraday-middleware work (which can't be used with faraday 2.0) before I decided to bump the requirement to at least 1.10 and make this easier :)
|
ianyamey
approved these changes
Oct 21, 2022
|
Closing as duplicate of #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of cleanup, mostly here to unlock using Faraday 2.x. See https://github.com/lostisland/faraday/blob/main/UPGRADING.md
Best I can tell there's no need for the middleware to follow redirects (from the JSON:API spec or the Unit API docs)