Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Authorizations resource #32

Conversation

trevornelson
Copy link
Contributor

Adds support for Authorizations resource from the Unit API. For now, we're only concerned with the list endpoint, and just pulling in the bare minimum fields for now to fix an issue where the dashboard doesn't show recent transactions. We can circle back later if we want to start pulling in rich merchant data or any other fields on the authorization resource.

@linear
Copy link

linear bot commented Sep 6, 2023

RET-2879 BUG: Incorrect account balance for spend account

Steps to reproduce

  • Go to your dashboard, note the spend account balance
  • Make a transaction with your spend card
  • Go back to your dashboard

Expected behavior

The initial account balance was decremented by the amount of the transaction.

Actual behavior

The account balance is unchanged until the transaction is processed in a day or so.

Reporting

https://retirable.slack.com/archives/C02SN663TB5/p1694003161768959?thread_ts=1692385352.346949&cid=C02SN663TB5

Priority

P1 - the issue needs to be invesigated within a few hours

@trevornelson trevornelson requested a review from a team September 6, 2023 19:42
Copy link
Contributor

@Eitansbd Eitansbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevornelson I think you need to bump the version in lib/unit-ruby/version.rb but tbh I don't think I've ever made a change to this gem myself. @ianyamey can you confirm?

@ianyamey
Copy link
Contributor

ianyamey commented Sep 7, 2023

@trevornelson I think you need to bump the version in lib/unit-ruby/version.rb but tbh I don't think I've ever made a change to this gem myself. @ianyamey can you confirm?

Yes, you’re right! We’ve been following semver so this should probably be a bump of the minor version

@trevornelson
Copy link
Contributor Author

@Eitansbd @ianyamey Yep! The readme made it seem like the convention was to get it reviewed first and then bump the version. I can update the readme to just have it all in one PR review though- I think that's a bit less hassle anyway.

@trevornelson trevornelson force-pushed the trevor/ret-2879-bug-incorrect-account-balance-for-spend-account branch from 0e5ca73 to 6caaf3d Compare September 7, 2023 17:22
@trevornelson trevornelson merged commit f83c913 into main Sep 7, 2023
2 checks passed
@trevornelson trevornelson deleted the trevor/ret-2879-bug-incorrect-account-balance-for-spend-account branch September 7, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants