Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CounterParty API resource #42

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

trevornelson
Copy link
Contributor

@trevornelson trevornelson commented Sep 3, 2024

We want to be able to generate counter parties for clients to make it easier for them to transfer funds between their BRB and Thread accounts. In order to do this, we need a AchCounterparty resource in addition to the Unit::Types::Counterparty (which is used for inline ACH payments). This'll allow us to create recipients that'll show as options in their ACH Component in the dashboard.

Copy link

linear bot commented Sep 3, 2024

@trevornelson trevornelson force-pushed the trevor/ret-3407-add-counterparties-support branch 4 times, most recently from 3391f56 to 78138e1 Compare September 3, 2024 21:37
@trevornelson trevornelson marked this pull request as ready for review September 3, 2024 21:50
@trevornelson trevornelson force-pushed the trevor/ret-3407-add-counterparties-support branch from 78138e1 to d0906d4 Compare September 3, 2024 21:53
@trevornelson trevornelson requested a review from a team September 3, 2024 22:08
Copy link
Contributor

@Eitansbd Eitansbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense. Not sure if it somehow now makes sense to remove the CounterParty type though and use this resource instead?

@trevornelson trevornelson merged commit d89cdfb into main Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants