Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sleep in time_util_test #197

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Remove sleep in time_util_test #197

merged 2 commits into from
Feb 27, 2019

Conversation

himkt
Copy link
Contributor

@himkt himkt commented Feb 27, 2019 •
edited
Loading

Overhead of calling sleep may cause a failure of the test.
In this context, we can test the behaviour of get_clock_time without sleep.

@himkt himkt changed the title Remove sleep Remove sleep in time_util_test Feb 27, 2019
@eiichiroi
Copy link
Contributor

LGTM! 💯

@eiichiroi eiichiroi merged commit 2fe4945 into retrieva:master Feb 27, 2019
@himkt himkt deleted the fix-time-util-test branch February 27, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himkt @eiichiroi