Add centos7 and centos8 jobs to CI #210
Merged
+134
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM!! Thx!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I've done
Added
centos7andcentos8jobs to CI.Note that different versions of mysql and postgresql are installed in each image.
docker.retrieva.jp/pficommon_ci:centos7.2008docker.retrieva.jp/pficommon_ci:centos8.2008Only mysql8 can be installed in CentOS8 but building pficommon fails with that version (see #209 ), so mysql is not installed in
docker.retrieva.jp/pficommon_ci:centos8.2008image.Also, postgresql11 and 12 requires
llvm-toolset-7-clangwhich is incentos-release-sclrepository and I'm not sure it is good to activate that repo only for postgresql. That's why postgresql10 is installed indocker.retrieva.jp/pficommon_ci:centos7.2008image.How to test
python3 build.pyand all images can be built.