Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube): Block crowdfunding tag in video subtitle #1141

Closed
3 tasks done
Domiiniik opened this issue Apr 17, 2023 · 2 comments
Closed
3 tasks done

feat(YouTube): Block crowdfunding tag in video subtitle #1141

Domiiniik opened this issue Apr 17, 2023 · 2 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Domiiniik
Copy link

Domiiniik commented Apr 17, 2023

Application

Youtube

Issue

Additionally disable distracting green crowdfunding tag from showing in videos in addition to box in "Remove Crowdfunding box" Patch.

Patch

Patch should remove this tag from the videos:
Screenshot_20230417_194918_YouTube
Screenshot_20230417_194900_YouTube

Motivation

Prevents user from distraction by removing described element visibility in feed as well as in Video Player.

  • User most likely doesn't care&doesn't want to see crowdfunding tag if he opted in to disable crowdfunding box anyway and taking into consideration that there are no other green UI elements in the video player it makes the tag distracting as mentioned above.

+Dealing with this would probably be not a lot of work when it comes to patch development anyways, but I'd be a nice addition to complete for the overall removal of "crowdfunding" related elements in the UI to give even cleaner UI experience that reVanced already provides anyways. :)

Offtopic: On provided screenshot reference you can also see "Hide action buttons Patch glitching out as reported in an issue by other user, its a pretty common issue since the beginning of this Patch existence and would be nice to finally give this Patch some love, have this fixed as well as have "Hide create,clip and thanks buttons" split to match the rest. It's the little ironing out things that matters now that the patches selection is rich.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Domiiniik Domiiniik added the Feature request Requesting a new feature that's not implemented yet label Apr 17, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
@oSumAtrIX oSumAtrIX mentioned this issue Mar 12, 2023
3 tasks
@Perry-God

This comment was marked as off-topic.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(patch-Improve Hide crowdfunding box patch): Block crowdfunding text tag in videos. feat(YouTube): Block crowdfunding tag in video subtitle Jun 1, 2024
@oSumAtrIX
Copy link
Member

Over time, a lot of feature requests have been made, which is why I am closing some according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

  • Stale for too long
  • Low priority
  • Maintainers un-interested
  • Too complex to realize

Regardless, anyone who comes across this feature request can PR it. Thanks for the feature request!

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants