Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(photomath): Patching "unlock-plus" fails on apk version 8.21.0 #1188

Closed
3 tasks done
Edgiest05 opened this issue Apr 4, 2023 · 4 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@Edgiest05
Copy link

Edgiest05 commented Apr 4, 2023

Type

Error while patching

Bug description

Attempting to patch latest Photomath play store version (8.21.0) fails

Steps to reproduce

Step 1. Select Photomath application in Revanced Manager
Step 2. Choose "unlock-plus" patch
Step 3. Apply patch (fails in progress)

Relevant log output

Initializing installer
Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
Deleting existing resource cache directory
Decoding resources
Applied predictive-back-gesture
Applied remove-screenshot-restriction
Failed to apply unlock-plus: 'unlock-plus' depends on 'SignatureDetectionPatch' but the following error was raised: java.lang.NullPointerException
	at app.revanced.patches.photomath.detection.signature.patch.SignatureDetectionPatch.execute(SignatureDetectionPatch.kt:30)
	at app.revanced.patches.photomath.detection.signature.patch.SignatureDetectionPatch.execute(SignatureDetectionPatch.kt:17)
	at app.revanced.patcher.Patcher.executePatches$executePatch(Patcher.kt:328)
	at app.revanced.patcher.Patcher.executePatches$executePatch(Patcher.kt:301)
	at app.revanced.patcher.Patcher.access$executePatches$executePatch(Patcher.kt:36)
	at app.revanced.patcher.Patcher$executePatches$1.invokeSuspend(Patcher.kt:350)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlin.sequences.SequenceBuilderIterator.hasNext(SequenceBuilder.kt:127)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda-20(MainActivity.kt:321)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$kxvfcFiIKARIH6oxYjk9gWWxjp0(Unknown Source:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda13.run(Unknown Source:22)
	at java.lang.Thread.run(Thread.java:1012)
Repacking patched apk
Compiling resources
Writing modified dex files
Finished!

Screenshots or videos

Choosing Patch
Output_1
Output_2

Solution

No response

Additional context

Android version: 12
Revanced manager version: 0.0.57
Photomath version: 8.21.0
No custom tweaks to the patching process

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Edgiest05 Edgiest05 added the Bug report Something isn't working label Apr 4, 2023
@xDARKxDEVILx
Copy link

There is a problem with patching Version 8.21.0 ,but patching 8.20.0 works just fine , just remember to download the apk version and select it from your storage( don't install it and then try to patch )

@Edgiest05
Copy link
Author

The workaround is much appreciated (thanks EhabxAlaa). I'll keep the issue open but with a more precise title.

@Edgiest05 Edgiest05 changed the title bug: Photomath "unlock-plus" fails bug(photomath): Patching "unlock-plus" fails on apk version 8.21.0 Apr 5, 2023
@badawoll
Copy link
Contributor

The fix has been implemented in #1886, now awaiting merge to main.

@Edgiest05
Copy link
Author

Amazing, I'll close the issue. Thanks badawoll for telling me.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants