Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(patch): Prepend the filename of downloaded videos with the username of the creator #1765

Closed
2 of 3 tasks
powerfulsaber opened this issue Nov 13, 2022 · 3 comments
Closed
2 of 3 tasks
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@powerfulsaber
Copy link

powerfulsaber commented Nov 13, 2022

Application

TikTok.

Issue

Due to the download patch removing watermarks, it makes it difficult to track down who the original creator was.

Patch

Prepend the filename of downloaded videos with the username of the creator.

I'd suggest changing the filename format to something like "{username}_{current date & time}" as it might go over its character limit if the username is too long when alongside the default naming scheme.

Motivation

If a user ever forgets who the creator was, they can simply look at its filename. This would allow watermarkless videos to hold a reference to the creator without their tag in the actual video

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@powerfulsaber powerfulsaber added the Feature request Requesting a new feature that's not implemented yet label Nov 13, 2022
@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2022
@powerfulsaber
Copy link
Author

powerfulsaber commented Nov 13, 2022

@oSumAtrIX Can I please know why this won't be added/planned?

@oSumAtrIX
Copy link
Member

Its closed as a duplicate.

@powerfulsaber
Copy link
Author

Apologies. Looks like it was a dupe of ReVanced/revanced-patches-template#2034. I think I missed this since I searched for "filename" rather than "file name".

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.167.0-dev.4](ReVanced/revanced-patches@v2.167.0-dev.3...v2.167.0-dev.4) (2023-03-19)

### Bug Fixes

* **youtube/sponsorblock:** fix segments not skipping during background play ([ReVanced#1765](ReVanced/revanced-patches#1765)) ([7620ea1](ReVanced/revanced-patches@71801c0))

### Features

* `export-all-activities` patch ([ReVanced#1751](ReVanced/revanced-patches#1751)) ([aad6e05](ReVanced/revanced-patches@0332ed4))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.167.0](ReVanced/revanced-patches@v2.166.0...v2.167.0) (2023-03-29)

### Bug Fixes

* **youtube/remember-playback-speed:**  allow to not remember playback speed ([ReVanced#1762](ReVanced/revanced-patches#1762)) ([49ec3e8](ReVanced/revanced-patches@59e66fe))
* **youtube/sponsorblock:** fix segments not skipping during background play ([ReVanced#1765](ReVanced/revanced-patches#1765)) ([7620ea1](ReVanced/revanced-patches@71801c0))
* **youtube/spoof-signature-verification:** fix audio during home feed video playback ([ReVanced#1754](ReVanced/revanced-patches#1754)) ([7dd067b](ReVanced/revanced-patches@b7d3ad7))

### Features

* `export-all-activities` patch ([ReVanced#1751](ReVanced/revanced-patches#1751)) ([aad6e05](ReVanced/revanced-patches@0332ed4))
* **reddit:** bump compatibility to `2023.10.0` ([ReVanced#1772](ReVanced/revanced-patches#1772)) ([f95ab6e](ReVanced/revanced-patches@20a4122))
* **twitter:** remove `monochrome-icon` patch ([ReVanced#1786](ReVanced/revanced-patches#1786)) ([b8bf804](ReVanced/revanced-patches@5bacf1a))
* **youtube/microg-support:** do not depend on `spoof-signature-verification` patch ([af4e765](ReVanced/revanced-patches@d370458))
* **youtube/spoof-signature-verification:** automatic signature spoofing ([f1395f4](ReVanced/revanced-patches@2096596))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

2 participants