bug(YouTube): the 2 hide audio track options describe doing the same thing (but in reality they are distinctly different)

[Adarshakarki]

Type

Cosmetic

Bug description

There are currently 2 hide audio track options.
One is in revanced>layout

And another is in layou>player flyout menu options

Steps to reproduce

Just patch normally with default patches

Relevant log output

No need log

Screenshots or videos

Solution

Remove option from revanced>layout. From my understanding audio track options only come in player flyout. So hide audio track in player flyout is only required.

Additional context

No response

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.

[LisoUseInAIKyrios]

There are two distinct buttons. One on the player, the other in the flyout menu.

The layout option hides a player UI button that shows up on some videos with a second audio track. (Search the closed PR's or issues and you'll find discussion and an example video).

The flyout menu option is an additional audio track button in the flyout menu (always present if there is a second audio track).

[LisoUseInAIKyrios]

The description of the player buttons could be improved to mention it's on the player UI.

[oSumAtrIX]

The layout option hides a player UI button that shows up on some videos with a second audio track

I have not seen it once, maybe they reverted it?

[LisoUseInAIKyrios]

Here is the original PR for the hide player buttons feature: #2021

And an example video:
https://youtu.be/1otF0N6surM

The extra audio track appears as both a button on the player UI, and as an entry in the video flyout menu.

The hide player button could be renamed to something like "Hide player audio button" or something like that.

[LisoUseInAIKyrios]

Instead of renaming the player Overlay button, a simpler option is to always hide the button and remove the ReVanced setting.

I can't see why anyone would want the player button to be shown, when the audio track can be changed in the flyout menu. Plus the audio button clashes with the copy url button, making it impossible to use if copy url is also enabled.

Nobody will notice the player button is always hidden, because the videos with this button also have an intro with instructions of how to enable the secondary audio using the settings flyout menu (and it never mentions using the player overlay button).

Always hiding the button would make the ReVanced settings simpler, and remove one more "what does that do?" Especially since the player audio button is rarely shown.

[oSumAtrIX]

@LisoUseInAIKyrios That sounds good to me. This would allow merging those two patches.