feat: (YouTube) Add "Hide Stats for nerds" in the "Player flyout menu items"

[54m4d]

Application

com.google.android.youtube

Issue

Hide an item in the Player flyout menu.

Patch

This patch/addition should hide Stats for nerds in the Player flyout menu

Motivation

All the items in the Player flyout menu have a toggle in the settings that hides them, except for Stats for nerds, so why not?

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.

[oSumAtrIX]

Because it can be hidden in YouTube

[54m4d]

Bro why are you always fast to close our issues? Are you in a hurry or something?

If you think it's in YouTube, The least you can do is to provide proof. Take a screenshot and put it here.

[oSumAtrIX]

First time seeing someone complaining about fast response time.

I don't need to proof anything, it's a Google search away.

[LisoUseInAIKyrios]

@54m4d the option is built into YouTube settings:

YouTube -> Settings -> General -> Stats for Nerds

The option is normally off, so you must have enabled it. It's silly and pointless for ReVanced to hide a menu the user intentionally enabled.

[54m4d]

No! that's the first thing i checked, it's off but i still see stats for nerds, that's why i asked to put the proof.

This is the behaviour i have ReVanced/revanced-patches-template#2240

[oSumAtrIX]

[LisoUseInAIKyrios]

I've never seen stats for nerds show up unless it's enabled in YouTube settings. It sounds like something is going wrong and it's showing the stats menu when it should not.

Try clearing the app data. If you have app spoofing enabled then turn it off. Try using incognito mode. And see if stock YouTube behaves the same (stats show up even though it's turned off in settings).

[54m4d]

Definitely something wrong with this option. Solution: although it's off by default, turn it on, then off, after that, the behaviour of this option works as intended.

As you can read in the comment i linked, that user had the same behaviour i experienced today. I never enabled stats for nerds but i could still see it in the player flyout menu until i performed the "solution" i mentioned above.

[LisoUseInAIKyrios]

Must be a bug in YouTube itself.

[54m4d]

That must have been going for so long then, but i can't tell for sure since i don't have the stock yt and probably not willing to check it either since my issue is resolved :)

All in all, it's just another reminder that good communication is key.

[johnconner122]

I've never seen stats for nerds show up unless it's enabled in YouTube settings. It sounds like something is going wrong and it's showing the stats menu when it should not.

It happens if you switch google account.