Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(YouTube - Theme): materialYou does not apply to Notification Badge #479

Open
3 tasks done
kazimmt opened this issue Aug 12, 2023 · 1 comment
Open
3 tasks done

bug(YouTube - Theme): materialYou does not apply to Notification Badge #479

kazimmt opened this issue Aug 12, 2023 · 1 comment
Labels
Bug report Something isn't working

Comments

@kazimmt
Copy link
Contributor

kazimmt commented Aug 12, 2023 •
edited
Loading

Type

Cosmetic

Bug description

After changing
@android:color/black -> @android:color/system_neutral1_900
&
@android:color/white -> @android:color/system_neutral1_50

MaterialYou applies in YouTube app body but not in Notification Badge

But according to Material Guideline, Badge should follow materialYou as well
Refer to: https://m3.material.io/components/badges/overview

Steps to reproduce

  • Change @android:color/black -> @android:color/system_neutral1_900 & @android:color/white -> @android:color/system_neutral1_50 in options
  • patch YouTube with Theme patch

Material You not applies in Notification Badge
259048026-669dece6-a6ee-4c89-894d-9540229f6cd0

Relevant log output

‍

Solution

Apply materialYou for notification badge
It may look like this:
IMG_20230812_151849

Additional context

Here is an example from Gmail App
IMG_20230812_151044

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@kazimmt kazimmt added the Bug report Something isn't working label Aug 12, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.56.0 [skip ci]
0bcaf39 
# [2.56.0](ReVanced/revanced-patches@v2.55.0...v2.56.0) (2022-09-15)

### Features

* **tiktok-download:** custom download path ([ReVanced#479](ReVanced/revanced-patches#479)) ([944aa48](ReVanced/revanced-patches@99b6135))
@kazimmt
Copy link
Contributor Author

kazimmt commented Jun 1, 2024

Adding these files in res folder may fix the issue
materialyou.zip

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube/Theme): materialYou doesn't applies in Notification Badge bug(YouTube - Theme): materialYou does not apply to Notification Badge Jun 2, 2024
oSumAtrIX added a commit that referenced this issue Oct 25, 2024
@leumasme @oSumAtrIX
refactor(Tumblr): Use a common filter patch (#479)
58c75c8 
Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kazimmt