Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(youtube/theme): seekbar is white and not red when device dark mode is enabled #582

Closed
3 tasks done
TheShadowRunner opened this issue Jul 19, 2023 · 6 comments · Fixed by ReVanced/revanced-patches-template#2663
Labels
Bug report Something isn't working

Comments

@TheShadowRunner
Copy link

Type

Cosmetic

Bug description

I use ReVanced Manager 1.4.1 to patch YT 18.23.35.
I select the "Theme" patch.
In all previous versions of the patch, the timeline right under videos used to be RED at all times.

Now the timeline is RED only when interacting with the timeline, otherwise in normal state it's WHITE.

Could you please revert the "Theme" patch so the timeline is -always- RED ? (while it has focus, no focus, interracted with or not..)

Thanks for your support.

Steps to reproduce

Patch YT 18.23.35 with ReVanced manager 1.4.1, select the "Theme" patch.

Relevant log output

None

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@TheShadowRunner TheShadowRunner added the Bug report Something isn't working label Jul 19, 2023
@LisoUseInAIKyrios
Copy link
Contributor

The seekbar showing as white is a newer YouTube feature. If you exclude the theme patch you'll see the seekbar is white when device dark mode is enabled.

If you want the seekbar to show red all the time, then change the seekbar color to any shade of red that is not #FF0000 (such as #FE0000, or #FF0001)

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title YT "Theme" patch, revert always RED timeline bug(youtube/theme): seekbar is white white and not red when device dark mode is enabled Jul 19, 2023
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Jul 19, 2023

I suppose the seekbar color could have a parent switch to enable/disable the custom color.
And if the switch is on then the seekbar never shows as white in dark mode (even if the custom color is #FF0000)

@TheShadowRunner
Copy link
Author

Thanks for your reply and these advanced details!
Could I maybe mod some file on my end to force always RED somehow ?
I'm using ReVanced Manager, system is not rooted.
In my case-use Theme will -never- be excluded so this simplifies things ?

@LisoUseInAIKyrios
Copy link
Contributor

The only option you have is to use any color except #FF0000

Go to ReVanced settings -> layout -> seekbar, and change the color to #FE0000. Then it'll be red all the time.

@TheShadowRunner
Copy link
Author

Excellent, it works! Thank you very much.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(youtube/theme): seekbar is white white and not red when device dark mode is enabled bug(youtube/theme): seekbar is white and not red when device dark mode is enabled Jul 19, 2023
@NBruderman
Copy link

The only option you have is to use any color except #FF0000

Go to ReVanced settings -> layout -> seekbar, and change the color to #FE0000. Then it'll be red all the time.

You have no idea how much I needed this comment in my life. Really.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
## [2.69.3](ReVanced/revanced-patches@v2.69.2...v2.69.3) (2022-09-27)

### Bug Fixes

* **sponsorblock:** correct class name for field reference ([ReVanced#582](ReVanced/revanced-patches#582)) ([7cd585c](ReVanced/revanced-patches@25ad854))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
## [2.69.3](ReVanced/revanced-patches@v2.69.2...v2.69.3) (2022-09-27)

### Bug Fixes

* **sponsorblock:** correct class name for field reference ([ReVanced#582](ReVanced/revanced-patches#582)) ([7cd585c](ReVanced/revanced-patches@25ad854))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants