Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(youtube): move copy video url link button to a different location #855

Closed
3 tasks done
Jakenevada opened this issue May 28, 2023 · 7 comments
Closed
3 tasks done
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Jakenevada
Copy link

Jakenevada commented May 28, 2023

Application

Youtube:Revanced

Issue

I know that there are some issues with hiding this buttons but i would like to ask if its possible to make copy link button like an seperate entity above the empty space so it would even apear above some buttons if the app is not spoffed or extra buttons being enabled

343725553_9440313896010888_5530632523957319207_n

Patch

Above

Motivation

More intuitive UI

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Jakenevada Jakenevada added the Feature request Requesting a new feature that's not implemented yet label May 28, 2023
@LisoUseInAIKyrios
Copy link
Contributor

This probably would not be difficult to do for the spoofed old layouts (they use native android code and buttons). But old layout is not what most people use and eventually the old layouts will stop working when google discontinues support for them (just as they did with YouTube version 15.x installs)

But it will probably be difficult to implement for the regular (modern non spoofed) layout, because so far nobody has figured out how to inflate additional items in a litho layout (this is also the reason the dislikes appear the way they do, and not as a new label to the right of the dislikes button).

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat: Copy link button relocation feat(youtube): move copy video url link button to a different location May 28, 2023
@Jakenevada
Copy link
Author

I would be glad for such option to be added to spoofed app if its not a hasle also i would like to ask when do you think spoofed interface would stop working ?

@LisoUseInAIKyrios
Copy link
Contributor

It's up to YouTube when they stop supporting 16.x. Maybe it'll be this year, maybe 5 years from now. Only YouTube knows.

@Jakenevada
Copy link
Author

Ok last question old interface is now only in 16.x version of app above it is a new one right ?

@LisoUseInAIKyrios
Copy link
Contributor

All the spoof app targets are the old UI, each with slightly different changes.

@Jakenevada
Copy link
Author

Ok thank you

@oSumAtrIX
Copy link
Member

Closing as out of scope currently.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.120.0](ReVanced/revanced-patches@v2.119.0...v2.120.0) (2022-11-23)

### Features

* **youtube:** `remove-player-button-background` patch ([ReVanced#855](ReVanced/revanced-patches#855)) ([9e14817](ReVanced/revanced-patches@621ec45))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants