Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify the user if revaultd has daemon=false in the conf #40

Closed
danielabrozzoni opened this issue Mar 5, 2021 · 0 comments · Fixed by #45
Closed

Notify the user if revaultd has daemon=false in the conf #40

danielabrozzoni opened this issue Mar 5, 2021 · 0 comments · Fixed by #45

Comments

@danielabrozzoni
Copy link
Collaborator

When starting revaultd from revault-gui, the UI freezes until the child process has terminated (see https://github.com/revault/revault-gui/blob/master/src/revaultd/mod.rs#L191-L194), but if daemon=false is in the configuration, the child process never terminates.
danielabrozzoni added a commit to danielabrozzoni/revault-gui that referenced this issue Mar 9, 2021
@danielabrozzoni
Notify users if they have daemon=false in the conf
ea115ea 
When starting revaultd from the GUI, notify the user if after 10 seconds
the child process still hasn't terminated - it means that revaultd was
started with daemon=false in the conf

Closes revault#40
@danielabrozzoni danielabrozzoni mentioned this issue Mar 9, 2021
Merged
edouardparis added a commit that referenced this issue Mar 11, 2021
@edouardparis
Merge #45: Notify users if they have daemon=false in the conf
ed9958d 
9f380fd Notify users if they have daemon=false in the conf (Daniela Brozzoni)

Pull request description:

  When starting revaultd from the GUI, notify the user if after 10 seconds
  the child process still hasn't terminated - it means that revaultd was
  started with daemon=false in the conf

  Closes #40

ACKs for top commit:
  edouardparis:
    ACK 9f380fd

Tree-SHA512: ccb3a3bd78c202646b3bb24084e17a5850d2599ea055200763e3674d49a037779e033b7aa99c325b10e945232e029045e5d0941ebfb70d73ed58c6fb0818482a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notify users if they have daemon=false in the conf danielabrozzoni/revault-gui
1 participant
@danielabrozzoni