control: remove the signature check logic, use revault_tx instead #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests were great, but it's even better to have nothing to test :) |
Yay for code removal!
darosior
force-pushed
the
remove_signature_check
branch
from
6bd675c
to
5d51920
Compare
danielabrozzoni
approved these changes
Oct 23, 2021
There was a problem hiding this comment.
ACK 5d51920 - unit and functional tests are passing locally
This was referenced Oct 29, 2021
darosior
added a commit
that referenced
this pull request
Nov 2, 2021
1d26384 ci: reduce parallelization (Antoine Poinsot) a1b42dd control: pass a slice of DbTransaction to share signatures to the coord (Antoine Poinsot) 444af2e db: separate RevaultTx helpers in a new bitcointx mod (Antoine Poinsot) 31951a0 Presigned txs signatures update overhaul (Antoine Poinsot) e99ebe1 sigfetcher: only fetch incomplete txs for vaults with expected statuses (Antoine Poinsot) 668e7f8 sigfetcher: fetch vaults in db only once (Antoine Poinsot) d621b8c tests: update coordinatord to latest master (Antoine Poinsot) Pull request description: This is a complete refactor of our signature update for in-DB transactions. With the upcoming watchtower integration, it was not reasonable to pile on top of the intricate logic of `db_update_presigned_tx` in the coordinator poller thread. This cleans up the signature update logic in the signature fetcher thread and as a consequence refactors the data structure used to represent the in-DB presigned transactions and the update of those via RPC. It's a pretty invasive refactoring, but with some upsides as it fixes #284 and partially tackles #145 . Refer to the commit messages for more details. ACKs for top commit: darosior: re-ACK 1d26384 Tree-SHA512: e8ec4decf76156364ea7144c77599109acfca129677392f9e969d8fdda9b877eb3152c68368b23894d628b9a0d51cebbab8a21405ad2fe8eaa56cc18776b8bbd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay for code removal!
Fixes #253